fix user permissions + improve notification system

2026-04-13 14:11:49 -05:00
parent c56a9f16f4
commit f28c0d33a9
12 changed files with 257 additions and 24 deletions
@@ -357,9 +357,14 @@ export function createNotificationPluginHandlers(deps: CreateDeps) {
        safeSendViewer(session.viewer, item);
      }

-      void deliverWebPushClientEvent(event, info, deps.canUserAccessClient, deps.getUserRole);
-
      const externalTargets = deps.getDeliveryTargetsForClientEvent(event, info.id);
+      const pushEnabledByUser = new Map(externalTargets.map((t) => [t.userId, t.clientEventPush]));
+
+      void deliverWebPushClientEvent(event, info, deps.canUserAccessClient, deps.getUserRole, (userId) => {
+        const enabled = pushEnabledByUser.get(userId);
+        return enabled !== undefined ? enabled : true;
+      });
+
      void deliverClientEventToExternalChannels(event, info, externalTargets);
    },