fix onboarding cache and remove the stupid renovate stuff

Overlord-Server/src/auth.test.ts

@@ -61,6 +61,7 @@ describe("account onboarding", () => {
       const meUrl = new URL("https://localhost/api/auth/me");
       const before = await handleAuthRoutes(new Request(meUrl, { headers }), meUrl, mockServer);
       expect(before?.status).toBe(200);
+      expect(before?.headers.get("cache-control")).toContain("no-store");
       expect((await before!.json()).needsOnboarding).toBe(true);
 
       const completeUrl = new URL("https://localhost/api/auth/onboarding/complete");
@@ -70,10 +71,19 @@ describe("account onboarding", () => {
         mockServer,
       );
       expect(completed?.status).toBe(200);
+      expect(completed?.headers.get("cache-control")).toContain("no-store");
 
       const after = await handleAuthRoutes(new Request(meUrl, { headers }), meUrl, mockServer);
       expect(after?.status).toBe(200);
       expect((await after!.json()).needsOnboarding).toBe(false);
+
+      const repeated = await handleAuthRoutes(
+        new Request(completeUrl, { method: "POST", headers }),
+        completeUrl,
+        mockServer,
+      );
+      expect(repeated?.status).toBe(200);
+      expect((await repeated!.json()).needsOnboarding).toBe(false);
     } finally {
       deleteUser(created.userId!);
     }

Overlord-Server/src/server/routes/auth-routes.ts

@@ -514,7 +514,10 @@ export async function handleAuthRoutes(
         permissions,
       }),
       {
-        headers: { "Content-Type": "application/json" },
+        headers: {
+          "Content-Type": "application/json",
+          "Cache-Control": "no-store, private",
+        },
       },
     );
   }
@@ -526,7 +529,21 @@ export async function handleAuthRoutes(
     }
 
     completeUserOnboarding(user.userId);
-    return Response.json({ ok: true, needsOnboarding: false });
+    const dbUser = getUserById(user.userId);
+    if (!dbUser || dbUser.onboarding_completed_at === null) {
+      return Response.json(
+        { error: "Could not save onboarding status" },
+        {
+          status: 500,
+          headers: { "Cache-Control": "no-store, private" },
+        },
+      );
+    }
+
+    return Response.json(
+      { ok: true, needsOnboarding: false },
+      { headers: { "Cache-Control": "no-store, private" } },
+    );
   }
 
   return null;