add legacy mode and some cleanup

This commit is contained in:
KingKDot
2026-08-20 09:01:27 -05:00
parent 3b6adf7b97
commit a9b7ca67ea
14 changed files with 257 additions and 100 deletions
@@ -115,6 +115,19 @@ func TestGetProcessesLockingFileShortPathDoesNotPanic(t *testing.T) {
_ = getProcessesLockingFile("a")
}
func TestIsBackstageLoaderExportSupportsBothCommandVersions(t *testing.T) {
for _, name := range []string{"ReflectiveLoader", "x012abc", "xffffff"} {
if !isBackstageLoaderExport(name) {
t.Fatalf("expected loader export %q to be accepted", name)
}
}
for _, name := range []string{"reflectiveloader", "x012ABc", "x12345", "x1234567", "other"} {
if isBackstageLoaderExport(name) {
t.Fatalf("expected loader export %q to be rejected", name)
}
}
}
func testEnvironmentBlock(t *testing.T, entries ...string) []uint16 {
t.Helper()
@@ -456,10 +456,10 @@ var CommandVersionSupport = map[CommandType]CommandVersionRange{
CommandBackstageSetQuality: {Min: 1, Max: 1},
CommandBackstageSetResolution: {Min: 1, Max: 1},
CommandBackstageStart: {Min: 1, Max: 1},
CommandBackstageStartBrowserInjected: {Min: 1, Max: 1},
CommandBackstageStartChromeInjected: {Min: 1, Max: 1},
CommandBackstageStartBrowserInjected: {Min: 1, Max: 2},
CommandBackstageStartChromeInjected: {Min: 1, Max: 2},
CommandBackstageStartProcess: {Min: 1, Max: 1},
CommandBackstageStartProcessInjected: {Min: 1, Max: 1},
CommandBackstageStartProcessInjected: {Min: 1, Max: 2},
CommandBackstageStop: {Min: 1, Max: 1},
CommandBackstageWindowList: {Min: 1, Max: 1},
CommandClientLogsRequest: {Min: 1, Max: 1},
@@ -17,14 +17,19 @@ func TestGeneratedWireContract(t *testing.T) {
if !ok {
t.Fatalf("missing version range for %s", command)
}
if versionRange.Min != 1 || versionRange.Max != 1 {
wantMax := 1
switch command {
case CommandBackstageStartBrowserInjected, CommandBackstageStartChromeInjected, CommandBackstageStartProcessInjected:
wantMax = 2
}
if versionRange.Min != 1 || versionRange.Max != wantMax {
t.Fatalf("unexpected version range for %s: %+v", command, versionRange)
}
if !IsSupportedCommandVersion(string(command), 1) {
t.Fatalf("%s must support v1", command)
}
if IsSupportedCommandVersion(string(command), 2) {
t.Fatalf("%s must not support undeclared v2", command)
if IsSupportedCommandVersion(string(command), 2) != (wantMax == 2) {
t.Fatalf("unexpected v2 support for %s", command)
}
}
if !IsCommandType("desktop_start") {