big optimizations

2026-03-22 23:21:27 -05:00
parent f69ca74346
commit 5c9c8dd543
18 changed files with 602 additions and 114 deletions
@@ -0,0 +1,113 @@
+import { afterAll, describe, expect, test } from "bun:test";
+import { deleteClientRow, listClients, setClientBookmark, upsertClientRow } from "./db";
+
+const createdClientIds: string[] = [];
+
+function createTempClient(id: string, options: { online: boolean; lastSeen: number; host: string; pingMs?: number; bookmarked?: boolean }) {
+  upsertClientRow({
+    id,
+    hwid: id,
+    role: "client",
+    host: options.host,
+    os: "windows",
+    arch: "amd64",
+    version: "1.0.0",
+    user: "tester",
+    country: "US",
+    lastSeen: options.lastSeen,
+    online: options.online ? 1 : 0,
+    pingMs: options.pingMs,
+  });
+  if (options.bookmarked) {
+    setClientBookmark(id, true);
+  }
+  createdClientIds.push(id);
+}
+
+function cleanupCreatedClients() {
+  while (createdClientIds.length > 0) {
+    const id = createdClientIds.pop();
+    if (id) {
+      deleteClientRow(id);
+    }
+  }
+}
+
+afterAll(() => {
+  cleanupCreatedClients();
+});
+
+describe("client list ordering", () => {
+  test("default sort keeps online clients above offline clients on the first page", () => {
+    try {
+      const prefix = `order-default-${Date.now().toString(36)}`;
+      const now = Date.now();
+
+      for (let index = 0; index < 12; index += 1) {
+        createTempClient(`${prefix}-offline-${index}`, {
+          online: false,
+          lastSeen: now - index,
+          host: `offline-${index}`,
+        });
+      }
+
+      createTempClient(`${prefix}-online`, {
+        online: true,
+        lastSeen: now - 60_000,
+        host: "online-host",
+      });
+
+      const result = listClients({
+        page: 1,
+        pageSize: 12,
+        search: prefix,
+        sort: "last_seen_desc",
+        statusFilter: "all",
+        osFilter: "all",
+        countryFilter: "all",
+        enrollmentFilter: "all",
+      });
+
+      expect(result.items.length).toBe(12);
+      expect(result.items[0]?.id).toBe(`${prefix}-online`);
+      expect(result.items[0]?.online).toBe(true);
+    } finally {
+      cleanupCreatedClients();
+    }
+  });
+
+  test("secondary sort modes still keep online clients above offline clients", () => {
+    try {
+      const prefix = `order-host-${Date.now().toString(36)}`;
+      const now = Date.now();
+
+      createTempClient(`${prefix}-offline-bookmarked`, {
+        online: false,
+        lastSeen: now,
+        host: "aaa-offline",
+        bookmarked: true,
+      });
+      createTempClient(`${prefix}-online`, {
+        online: true,
+        lastSeen: now - 1_000,
+        host: "zzz-online",
+      });
+
+      const result = listClients({
+        page: 1,
+        pageSize: 12,
+        search: prefix,
+        sort: "host_asc",
+        statusFilter: "all",
+        osFilter: "all",
+        countryFilter: "all",
+        enrollmentFilter: "all",
+      });
+
+      expect(result.items[0]?.id).toBe(`${prefix}-online`);
+      expect(result.items[0]?.online).toBe(true);
+    } finally {
+      cleanupCreatedClients();
+    }
+  });
+});