fix rbac and crit process

Overlord-Server/src/main-server.ts

@@ -13,7 +13,7 @@ import { v4 as uuidv4 } from "uuid";
 import { authenticateRequest } from "./auth";
 import { loadConfig, getConfig } from "./config";
 import { flushAuditLogsSync } from "./auditLog";
-import { getUserById, getUsersForNotificationDelivery, getUsersForNotificationDeliveryByClient, canUserAccessClient, setUserClientAccessRule, setUserClientAccessScope, getUserClientAccessScope, hasPermission } from "./users";
+import { getUserById, getUsersForNotificationDelivery, getUsersForNotificationDeliveryByClient, getUsersForNotificationDeliveryByClientOwnership, isClientOwnedByUser, canUserAccessClient, setUserClientAccessRule, setUserClientAccessScope, getUserClientAccessScope, hasPermission } from "./users";
 import { requireAuth, requirePermission } from "./rbac";
 import { metrics } from "./metrics";
 import { ensureDataDir } from "./paths";
@@ -326,7 +326,7 @@ const toDeliveryTarget = (u: any): UserDeliveryTarget => ({
 
 const deliverNotificationWithScreenshotForRecord = (record: NotificationRecord) => {
   const getUserDeliveryTargets = (clientId: string): UserDeliveryTarget[] =>
-    getUsersForNotificationDeliveryByClient(clientId).map(toDeliveryTarget);
+    getUsersForNotificationDeliveryByClientOwnership(clientId).map(toDeliveryTarget);
   return deliverNotificationWithScreenshot(record, getUserDeliveryTargets);
 };
 
@@ -346,12 +346,7 @@ const notificationPluginHandlers = createNotificationPluginHandlers({
   forwardPluginEventToRuntime: (clientId, pluginId, event, payload) =>
     pluginRuntime.dispatchClientEvent(clientId, pluginId, event, payload),
   getDeliveryTargetsForClientEvent: (event: string, clientId: string): UserDeliveryTarget[] => {
-    if (event === "client_purgatory") {
-      return getUsersForNotificationDelivery()
-        .filter((u) => u.role === "admin" || u.role === "operator")
-        .map(toDeliveryTarget);
-    }
-    return getUsersForNotificationDeliveryByClient(clientId).map(toDeliveryTarget);
+    return getUsersForNotificationDeliveryByClientOwnership(clientId).map(toDeliveryTarget);
   },
   savePluginState,
 });

Overlord-Server/src/users.ts

@@ -1228,6 +1228,35 @@ export function getUsersForNotificationDeliveryByClient(clientId: string): UserD
   );
 }
 
+function getClientOwnerUserId(clientId: string): number | null {
+  if (!clientId) return null;
+  try {
+    const row = db
+      .prepare("SELECT built_by_user_id FROM clients WHERE id = ?")
+      .get(clientId) as { built_by_user_id: number | null } | undefined;
+    if (!row || row.built_by_user_id == null) return null;
+    return typeof row.built_by_user_id === "number" ? row.built_by_user_id : null;
+  } catch {
+    return null;
+  }
+}
+
+export function getUsersForNotificationDeliveryByClientOwnership(
+  clientId: string,
+): UserDeliveryRow[] {
+  const ownerId = getClientOwnerUserId(clientId);
+  const all = getUsersForNotificationDelivery();
+  if (ownerId != null) {
+    return all.filter((user) => user.id === ownerId);
+  }
+  return all.filter((user) => user.role === "admin");
+}
+
+export function isClientOwnedByUser(userId: number, clientId: string): boolean {
+  const ownerId = getClientOwnerUserId(clientId);
+  return ownerId != null && ownerId === userId;
+}
+
 
 export interface RegistrationKey {
   id: number;